Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix OrderedTable iterators #11562

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

narimiran
Copy link
Member

This solves the bug reported on IRC:

import tables

# You can for loop over an auto initialized sequence of "Table"
var test = newSeq[Table[string, string]](1)
for key, table in test:
  for k, v in table:
    discard

# So I suppose it should work for "OrderedTable" too, but that crashes
var test2 = newSeq[OrderedTable[string, string]](1)
for key, table in test2:
  for k, v in table:
    discard

@Varriount Varriount merged commit 3d50f7e into nim-lang:devel Jun 23, 2019
narimiran added a commit that referenced this pull request Jun 27, 2019
@narimiran narimiran deleted the fix-ordered-table-iterators branch September 3, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants